Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://github.com/sebastianbergmann/phpunit/issues/5641 #5645

Merged
merged 2 commits into from
Jan 7, 2024
Merged

https://github.com/sebastianbergmann/phpunit/issues/5641 #5645

merged 2 commits into from
Jan 7, 2024

Conversation

marac19901990
Copy link
Contributor

Issue:

  • The TestSuite was never filtered because getIterator method was never called which is responsible to run the filtering.

Solution::

  • Code fixed to apply the expected filtering which solves the issue. Test added to cover this issue.

@marac19901990 marac19901990 mentioned this pull request Jan 7, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13087a8) 89.41% compared to head (d29dba5) 89.41%.

Additional details and impacted files 
@@            Coverage Diff            @@
##               10.5    #5645   +/-   ##
=========================================
  Coverage     89.41%   89.41%           
  Complexity     6417     6417           
=========================================
  Files           682      682           
  Lines         20406    20406           
=========================================
  Hits          18247    18247           
  Misses         2159     2159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann added feature/test-runner CLI test runner type/bug Something is broken labels Jan 7, 2024
@sebastianbergmann sebastianbergmann self-assigned this Jan 7, 2024
@sebastianbergmann sebastianbergmann added the feature/events Issues related to PHPUnit's event system label Jan 7, 2024
@sebastianbergmann sebastianbergmann merged commit 6055aa3 into sebastianbergmann:10.5 Jan 7, 2024
31 checks passed
@marac19901990 marac19901990 deleted the 10.5-filter-event branch January 7, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/events Issues related to PHPUnit's event system feature/test-runner CLI test runner type/bug Something is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marac19901990 @sebastianbergmann